Skip to content

stream: move _stream_* to end-of-life#60657

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
bjohansebas:streams_eol
Jan 22, 2026
Merged

stream: move _stream_* to end-of-life#60657
nodejs-github-bot merged 1 commit intonodejs:mainfrom
bjohansebas:streams_eol

Conversation

@bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Nov 9, 2025

So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

Review requested:

  • @nodejs/streams
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 9, 2025
@bjohansebas bjohansebas added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 9, 2025
@bjohansebas
Copy link
Member Author

bjohansebas commented Nov 9, 2025 •
edited
Loading

cc: @nodejs/tsc since it’s an end-of-life deprecation

@bjohansebas bjohansebas added the deprecations Issues and PRs related to deprecations. label Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (60b9aaa) to head (685d817).
⚠️ Report is 530 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60657   +/-   ##
=======================================
  Coverage   88.54%   88.55%           
=======================================
  Files         703      697    -6     
  Lines      208077   208035   -42     
  Branches    40082    40078    -4     
=======================================
- Hits       184252   184219   -33     
- Misses      15848    15850    +2     
+ Partials     7977     7966   -11
Files with missing lines Coverage Δ
lib/internal/main/mksnapshot.js 95.75% <ø> (-0.12%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjohansebas bjohansebas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70166/

@bjohansebas bjohansebas added review wanted PRs that need reviews. stream Issues and PRs related to the stream subsystem. labels Nov 21, 2025
@bjohansebas bjohansebas added review wanted PRs that need reviews. and removed review wanted PRs that need reviews. labels Dec 18, 2025
@bjohansebas
Copy link
Member Author

bjohansebas commented Dec 18, 2025 •
edited
Loading

Hey @nodejs/streams and @nodejs/tsc please review

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed review wanted PRs that need reviews. labels Dec 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70616/

@aduh95 aduh95 added the needs-citgm PRs that need a CITGM CI run. label Dec 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70929/

@bjohansebas
Copy link
Member Author

bjohansebas commented Jan 20, 2026

friendly ping @nodejs/tsc

@bjohansebas bjohansebas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2026
@nodejs-github-bot nodejs-github-bot merged commit c755b01 into nodejs:main Jan 22, 2026
98 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2026

Landed in c755b01

@bjohansebas bjohansebas deleted the streams_eol branch January 22, 2026 19:11
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
@bjohansebas @islandryu
stream: move _stream_* to end-of-life
ab2ba88 
PR-URL: nodejs#60657
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@bjohansebas bjohansebas added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 31, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @bjohansebas.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@legendecas legendecas legendecas approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@avivkeller avivkeller avivkeller approved these changes

@gurgunday gurgunday gurgunday approved these changes

+1 more reviewer

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bjohansebas @nodejs-github-bot @mcollina @ronag @legendecas @Ethan-Arrowood @avivkeller @gurgunday @AugustinMauroy @aduh95